samvera / questioning_authority

Question your authorities
Other
54 stars 30 forks source link

[WIP] add language processing to ldpath service #284

Open elrayle opened 4 years ago

elrayle commented 4 years ago

[WIP] Pending change in ldpath gem


Fixes #288; Partially addresses #289

The ldpath_service was not honoring requests for languages. With this change, if languages are passed into the ldpath_program method and the property being requested has a language marker in it, the program will create a request for each language and for all untagged literals.

The ldpath_execute method will recombine these values into language tagged RDF::Literals.

Without this, the language processing in QA is unable to properly sort multiple values within a single language.

jrgriffiniii commented 2 years ago

Apologies for any annoyance, but this is to please document and confirm that https://github.com/samvera-labs/ldpath/pull/18 is actually a blocking PR for merging these proposed changes.