search

samvera / questioning_authority

Question your authorities
Other
54 stars 30 forks source link

Rails 6.0? #287

Closed jrochkind closed 3 years ago

jrochkind commented 4 years ago

The qa gemspec is limited to Rails 5.x

(note that it allows 5.0.x, even though #221 suggest that maybe 5.0 wasn't meant to be supported anymore?)

I would like to upgrade my qa-using app to Rails 6.0. It's possible qa works just fine in 6.0 if only it's gemspec would allow it? I haven't tried yet.

Anyone looked into this? Any plans for 6.0 support?

jrochkind commented 4 years ago

I wanted to experimentally see if it would pass tests on 6.0, or if not what the failures were... but I am not able to run tests on unchanged master. The README suggests bundle install followed by rake ci should do it. That gets me an error:

NoMethodError: undefined method `version' for nil:NilClass
/Users/jrochkind/.gem/ruby/2.5.3/gems/engine_cart-2.3.0/lib/engine_cart/tasks/engine_cart.rake:62:in `block (3 levels) in <top (required)>'
/Users/jrochkind/.gem/ruby/2.5.3/gems/engine_cart-2.3.0/lib/engine_cart/tasks/engine_cart.rake:30:in `block (2 levels) in <top (required)>'
/Users/jrochkind/.gem/ruby/2.5.3/gems/engine_cart-2.3.0/lib/engine_cart/tasks/engine_cart.rake:113:in `block (2 levels) in <top (required)>'
/Users/jrochkind/.gem/ruby/2.5.3/gems/rake-13.0.1/exe/rake:27:in `<top (required)>'
Tasks: TOP => engine_cart:create_test_rails_app
jrochkind commented 4 years ago

If I "fork" qa, just to make the change to gemspec to allow rails 6, and use it in my app under rails 6.... the qa functionality I am using seems to work fine.

Which doesn't necessarily mean all qa func works fine.

I could try just making a PR with Rails 6 to see if it passes CI? I suspect it won't because of test/CI setup problems, not necessarily because any actual func won't work under Rails 6.

Not quite sure how to proceed, advice welcome!