search

samvera / questioning_authority

Question your authorities
Other
54 stars 30 forks source link

optionally include IP info at start of search/find linked data requests #302

Closed elrayle closed 4 years ago

elrayle commented 4 years ago

Marks the start of each linked data search/find request. Unless Qa.config.suppress_ip_data_from_log, this marker will include IP address, city, state, and country as reported by the geocoder gem.

NOTE: This also removes inclusion of the request_id directly in the logging messages. To include request_id, it is recommended that you set up the logger to do this automatically in config/environments/development.rb (or relevant env file) using…

config.log_tags = [:request_id]
jrochkind commented 4 years ago

Is it a concern that geocode-lookup of every IP address for log line may take non-trivial amounts of time, and add to response times when such logging is turned on?