samvera / questioning_authority

Question your authorities
Other
54 stars 30 forks source link

QA constructs questionable GeoNames URIs #306

Closed no-reply closed 4 years ago

no-reply commented 4 years ago

The GeoNames service performs search via the JSON API, then constructs a geonames linked data URI from the ID.

This process hard codes the protocol as http://. GeoNames does respond to these URIs, but when it does, it now (for at least a year) returns data about a different resource with protocol prefix https://. Unless clients know to make this replacement for GeoNames specifically, they'll not be able to interpret the response as containing data about the requested resource. This results in bugs like: https://github.com/samvera/hyrax/issues/3269

Replacing the hard coded http:// with https:// would be more in line with actual practice at GeoNames, and allow clients to avoid special protocol replacement behavior.