search

samvera / questioning_authority

Question your authorities
Other
54 stars 30 forks source link

allow rails 6.1 #332

Closed jrochkind closed 3 years ago

jrochkind commented 3 years ago

This PR does nothing except change the gemspec to allow Rails 6.1. Curious if CI will pass like this?

I am unable to run tests locally per #331, so this is a way to see if CI will run tests for me to see what happens, sorry.

Closes #330

jrochkind commented 3 years ago

Ah, circleci would have to be changed to actually run tests under rails 6.1 too.

I am not too familiar with circle-ci, but i'll see if I can figure it out.

jrochkind commented 3 years ago

Rails 6.1 build seems to fail with:

Don't know how to build task 'webpacker:install' (See the list of available tasks with `rails --tasks`)

I'm not sure what's going on there, why webpacker:install wouldn't be available if it was really a rails 6.1 app (or even a rails 6.0 app) that engine cart was creating... so maybe it's not somehow? This is beyond the quick fix I was hoping for, so I guess it's demonstrated it needs more than just a gemspec change to work with rails 6.1.

I am also not sure how to control what jobs show up as "required" in github list above; some do some don't, the new 6.1 one does not.

jrochkind commented 3 years ago

in my own app, if I fork qa to allow rails 6.1, and upgrade to rails 6.1.... my own apps tests pass, and it's functionality supported by qa works fine. I think it's possible this is just a test setup issue, and qa actually works fine with rails 6.1.

jrochkind commented 3 years ago

Huh wait a seccond, rails 6-1 test is showing up green in github here.

And weird, when I click on it... it looks like it was passing in circleci?? Not sure why I swear I saw it failing before!

So... maybe qa passes tests fine on railas 6.1 and just needs a merge and release?

jrochkind commented 3 years ago

Thank you! And for quick release, that's so helpful, I appreciate it!

I corrected my typo in title of this PR, it allows rails 6.1, not 6.2.