search

samvera / questioning_authority

Question your authorities
Other
54 stars 30 forks source link

Allow Faraday 2.x again #354

Closed jrochkind closed 2 years ago

jrochkind commented 2 years ago

I am interested in upgrading an app that uses the qa gem to use faraday 2.x, to get advantage of new features and bugfixes, but I can't do that if qa doesn't allow it.

tests seem to pass fine with latest faraday 2. I believe the issue that resulted in limiting to faraday 1.x only at 8378088 may have been resolved in faraday 2.0.1. I have excluded Faraday 2.0.1 as allowed, following advice at Faraday upgrading guide "We strongly suggest you to skip version 2.0 and instead use version 2.0.1 or greater."

jrochkind commented 2 years ago

i don't believe the CI is running, and I don't know if I have any way to trigger it. Can anyone help? @jrgriffiniii @elrayle ?

cjcolvar commented 2 years ago

CircleCI never kicked off a build. I tried manually creating a pipeline through the api, but couldn't get it to work.
@jrochkind could you try pushing this branch again? You might need to do something like git commit --amend to give it a new commit hash so it will look like something has changed.

jrochkind commented 2 years ago

Thanks @cjcolvar !

I did a git commit --amend to re-trigger things... it still doesn't look like circleci is kicking off a build?

if you couldn't do it manually either... there may be something wrong with the circleci setup?

I don't know much about circleci and I'm not sure how much help I can be in debugging it. I don't believe it has anything to do with this PR?

I could try to run all tests locally (not sure how hard it is for me to do that), if you'd take attestation of a green local test run as reasonable to commit?

jrochkind commented 2 years ago

Thanks @jrgriffiniii ! Any thoughts on a release that would include this?