Call `super()` in a bunch of initializers

samvera / questioning_authority

Question your authorities

Other

54 stars 30 forks source link

Call `super()` in a bunch of initializers #359

Closed eddierubeiz closed 2 years ago

eddierubeiz commented 2 years ago

Lint/MissingSuper wants us to call super() at the beginning of these initializers.

I'm mindful of the discussion at https://github.com/rubocop/ruby-style-guide/issues/809 but this looks to me like a harmless change.

jrochkind commented 2 years ago

The superclass(es) involved (mostly/all Qa::Authorities::Base?) doesn't seem to HAVE an initializer defined... I don't think this does anything... but if future rubocop is going to require it (once we add more ruby versions), which I think is where these come from, I guess our job is to satisfy rubocop?