search

samvera / questioning_authority

Question your authorities
Other
54 stars 30 forks source link

Run CI with Ruby 3.2 #381

Closed jrochkind closed 1 year ago

jrochkind commented 1 year ago

Locally tests passed under Rails 7.0 and Ruby 3.2 with no changes to code.

jrochkind commented 1 year ago

OK apparently I jumped the gun, very confusing. See also https://github.com/samvera/browse-everything/pull/416#issuecomment-1375966243 where I ran into the same problem, copy pasting:

OK, this is weird. The failure on ruby 3.2 is that:

nokogiri-1.13.10-x86_64-linux requires ruby version < 3.2.dev, >= 2.6, which is incompatible with the current version, ruby 3.2.0p0

It looks like there is no non-pre-release version of nokogiri out that actually works with ruby 3.2 yet? Only 1.14.0.rc1?

Yet I have other CI on projects using nokogiri which definitely passed on ruby 3.2 already, very weird, I wonder what I did in those....

jrochkind commented 1 year ago

@cjcolvar wait, did it pass CI? Last I saw it hadn't passed CI... wait, it appears to be recorded as passing CI?

Very weird, I wonder what changed from when it failed with the message I posted above! Kind of disturbing.

Oh well... thanks?!