Documentation for "How to Review a PR"

samvera / samvera.github.io

Public website for version controlled Samvera documentation (mostly Hyrax)

http://samvera.github.io

Apache License 2.0

7 stars 17 forks source link

Documentation for "How to Review a PR" #193

Open tpendragon opened 6 years ago

tpendragon commented 6 years ago

Need documentation for the practices behind reviewing a PR.

May include things from:

https://samvera.github.io/best-practices-coding-styles.html https://samvera.github.io/how-to-pr.html https://github.com/samvera/hyrax/blob/master/.github/CONTRIBUTING.md#reviewing-and-merging-changes

tpendragon commented 6 years ago

Ping @cam156, @hackmastera, @tpendragon, @no-reply, @mjgiarlo, @jcoyne, @jeremyf, @elrayle, and anyone else who commonly does PRs - what's good info to put here?

tpendragon commented 6 years ago

Add some info about using git blame to identify people who likely would be able to review.

RudyOnRails commented 6 years ago

Possiby a link to supporting article @jenlindner mentioned? https://medium.com/@sandya.sankarram/unlearning-toxic-behaviors-in-a-code-review-culture-b7c295452a3c