search

samvera / valkyrie

A Data Mapper library to enable multiple backends for storage of files and metadata in Samvera
Other
34 stars 23 forks source link

Dry::Types::Params::* missing from Valkyrie::Types #933

Open cgalarza opened 1 year ago

cgalarza commented 1 year ago

Dry::Types::Params::* definitions are not included in Valkyrie::Types. I am not sure if this is intentional because all the other built-in dry-type classes listed here (besides Maybe types) are included. I think the definition of Valkyrie::Types::Params::ID might be overriding all the other Params definitions. I can get around it for now by using Dry::Types['params.nil'] so its not a huge problem, but I thought I would document it here. If this isn't the desired behavior I can look into how to fix it.

tpendragon commented 1 year ago

If you want to get the other Params types working, I think that'd be a great addition!