search

samvermette / SVPullToRefresh

Give pull-to-refresh & infinite scrolling to any UIScrollView with 1 line of code.
http://samvermette.com/314
MIT License
4.82k stars 1.09k forks source link

Pull to refresh view doesn't always hide cleanly #131

Open lordkev opened 11 years ago

lordkev commented 11 years ago

I'm running into an issue where the pull to refresh view doesn't always hide cleanly after calling stopAnimating. I haven't been able to nail down exactly what conditions it occurs under, aside that it appears somewhat "random" in my use.

I did however nail it down to this commit that is causing the issue: b88f78db6073aa3bba06ddbd50148e8270f4824e (from #99)

If I revert this commit then the pull to refresh view always hides cleanly, but I'm not sure how best to solve it so that @pilot34's use case also works.

Any ideas?

pilot34 commented 11 years ago

It's ok if you revert my commit if nobody has the same problem. I'm working in branch

raphaeloliveira commented 11 years ago

@samvermette I had the same problem, the pull to refresh sometime only partial hide. I solved this problem as suggested @lordkev reverting the commit. Could you do that in the cocoa pods version?

zhuhao528 commented 11 years ago

I had the same problem with latest version. i found that stop stopAnimating is performed,but it do nothing when the network is closed or network is quick. how to solved it.

fustalol commented 9 years ago

same here.

mattmcneeney commented 9 years ago

I was also affected by this issue when using with a very fast internet connection, leading to a very short time period between calls to startAnimating() and stopAnimating().

Since the podspec hasn't been updated in 3 years, the fix referenced that has been committed to master hasn't made it through to the default pod yet.

You can workaround this for now by replacing

pod 'SVPullToRefresh'

with 

pod 'SVPullToRefresh', :git => 'https://github.com/samvermette/SVPullToRefresh.git', :branch => 'master'
jeffctown commented 8 years ago

Thanks @mattmcneeney! Spent 2 hours debugging this before I saw your comment.