search

samvloeberghs / protractor-gherkin-cucumberjs-angular

An example project to setup E2E or unit tests with Jasmine or CucumberJS with Gherkin scenarios in Protractor & Angular
http://samvloeberghs.github.io/protractor-gherkin-cucumberjs-angular2-slides/
MIT License
80 stars 31 forks source link

update to webpack 2.2.x #48

Open samvloeberghs opened 7 years ago

samvloeberghs commented 7 years ago

Updating to webpack 2.2.x requires quite a lot of work in the webpack configs ..

samvloeberghs commented 7 years ago

remove HMR bloat from example project

Fiontan commented 7 years ago

Please see my comment on #55 I have this running in an angie4 cli/webpack 2.2.x project and for the most part, the webpack config is hidden with the cli -thank God (I may be missing something though :)).

DennisJaamann commented 7 years ago

I actually have this update available in a local branch, just need to launch the PR. However, if we are going to use Angular CLI these changes might be obsolete. Let me know how you guys wish to proceed.

samvloeberghs commented 7 years ago

I'm not completely in favour of using CLI.. If you can update @DennisJaamann, please do

Fiontan commented 7 years ago

@samvloeberghs Hi Sam...can you expand upon the "not completely in favour of using CLI" comment please?

samvloeberghs commented 7 years ago

I like to keep it configurable.. I also have the impression that CLI makes you "stupid" about the use of webpack.. You said you were glad that the webpack config did not need exposed.. Well I don't mind cause I've been doing webpack for years :p

to be honest I never saw the added value of cli, except for the nice working configuration.

Fiontan commented 7 years ago

I understand Sam although there are rumours that the angular cli team are working on a plugin system for configurability- I think this is a good thing particularly for angular applications as it means that everything will be more standardised. This is your repo and so your direction is paramount although I for one would rather not be fighting with webpack configuration when I could be developing. For example, I mentioned that the register specs were not running correctly after I upgraded to ang4 webpack latest/cli. I suspect this may be something hidden away in the ang cli default webpack config, but wouldn't know where to start to investigate- and this is a common problem with webpack- those that understand it well are few and far between and for me, this is a major drawback for application teams.

samvloeberghs commented 7 years ago

@Fiontan I favor the wishes of the community over mine: please see https://github.com/samvloeberghs/protractor-gherkin-cucumberjs-angular/issues/56. So I am in favor of moving to cli. There are some requirements tough.. To be honest I don't have the time right now to do it, so if you and/or @DennisJaamann want to be of help, please.