search

samvloeberghs / protractor-gherkin-cucumberjs-angular

An example project to setup E2E or unit tests with Jasmine or CucumberJS with Gherkin scenarios in Protractor & Angular
http://samvloeberghs.github.io/protractor-gherkin-cucumberjs-angular2-slides/
MIT License
80 stars 31 forks source link

Update to latest angular 4 #55

Open samvloeberghs opened 7 years ago

samvloeberghs commented 7 years ago

We should update our code to angular 4

Fiontan commented 7 years ago

Hi Sam, this is a great little implementation of using cucumber with angular. I have been plaing around with it the last few days and it works like a charm (I'm new to cucumber and it's a relevation!!). I have integrated your source into an angular cli project using angular 4, latest web pack, latest protractor and locked the package versions down using Yarn. I see there are a number of issues "Help wanted" etc that touch upon these areas. WOuld you be interested in having a chat about what I have done and how we could integrate? Thanks for the leg up on a great project, Regards Fiontan

samvloeberghs commented 7 years ago

Hi there @Fiontan, Thanks for your feedback! Much appreciated..

About ng4 and cli.. for me it's even better if we could integrate this with CLI.. I would like to have the 2 approaches tough.. Running the Cucumber E2E test should be totally independent of the webpack config and the Angular application

samvloeberghs commented 7 years ago

Please provide a plan of updates and work if you'd like to contribute, I will be available for help and feedback :)

Fiontan commented 7 years ago

HI @samvloeberghs , I have uploaded your source and my changes to bitbucket and will forward a link presently. The tests are run the same either by issuing the 'ng e2e' command or simply 'protractor' from teh command line- the result is the same regardless. Isthat what you mean regarding ' Running the Cucumber E2E test should be totally independent of the webpack config and the Angular application'? If so it's already good to go...

Fiontan commented 7 years ago

@samvloeberghs please see your gmail inbox for an invitation to the bitbucket repo.

samvloeberghs commented 7 years ago

Seems to be working nice.. Could you be interested in updating this project to incorporate your changes here?

Fiontan commented 7 years ago

@samvloeberghs regrading your comment #48 do you want to proceed? I noticed an issue on saturday with the register specs- they don't seem to run completely after my upgrade so perhaps some further investigation is merited.

samvloeberghs commented 7 years ago

@Fiontan can we take the discussion of github? contact me on google hangouts or skype ( sam.vloeberghs )