search

samvozza / IAPTAssessment

Other
1 stars 0 forks source link

Collection name is not ensured to be unique per user #37

Closed cjf521 closed 8 years ago

cjf521 commented 8 years ago

Name does not have to be unique in the entire database (e.g. all users might have the 'Default' collection), but each user should not have more than one collection with the same name.

dochal commented 8 years ago

I am not sure whether we should limit the users in that respect. There is no harm (if the user chooses to) in having the same collection name

cjf521 commented 8 years ago

The only situation I can think of where this could possibly solve a problem is if the user wants to partition a collection into Public and Private parts, in which case they could distinguish them by the icons. There are better ways to support this than allowing the same collection name.

In all other cases, this only seems likely to cause confusion, especially when this is built into the interface for trading then presented to other users. It would allow us to protect against problems, and I don't think any users would be surprised by this particular requirement (and probably never meant to do it anyway).

arandomoracle commented 8 years ago

Fixed by eb238a5.