samwho / spacer

CLI tool to insert spacers when command output stops
https://github.com/samwho/spacer
MIT License
853 stars 9 forks source link

Timezone Aware #13

Closed simonwiles closed 11 months ago

simonwiles commented 11 months ago

This is an attempt at resolving #12; I have little experience with rust, but just depending on the chrono crate was very straightforward and seems to work great on all the systems I've tried it on.

Does this look like it might be acceptable? What more would you want to see to consider merging something like this?

Thanks!

samwho commented 11 months ago

This looks great to me.

In the beginning I did use chrono, but decided to get rid of it and rely directly on time because chrono, at the time (ha!), was depending on an old version of time that had some security advisories against it. It would appear they have fixed this in recent releases, so we can depend on it again 🥳

Thanks so much for your efforts on spacer, I greatly appreciate them.

simonwiles commented 11 months ago

Terrific, thanks! I find I'm using spacer all the time, and I'm delighted to be able to contribute a little 😁