Closed CatalanCabbage closed 5 months ago
Created PR downstream to address my comments here.
Add several more downstream PRs to add some extra functionality.
1) Invisible characters (https://github.com/CatalanCabbage/symbol.wtf/pull/2) 2) Autofocus (https://github.com/CatalanCabbage/symbol.wtf/pull/3).
I'm going to merge this into a staging branch and apply the review comments from @qwell. Thank you both for your contributions :)
If you give me a minute, I'll get my rollup branch pointed to yours and open a separate PR.
Ahh sorry, I already did the merge. If you rebase off main
and open a new PR I'll take a look 🙏
Ahh sorry, I already did the merge. If you rebase off
main
and open a new PR I'll take a look 🙏
Split symbols out of the HTML
name
,searchTerms
etc which brings me to....Add a rudimentary search bar
A simple search bar has been added which performs a naive search across the symbols.
It takes data from the array
searchTerms
, concats them and checks for a partial match.Should be good enough for a long time. Unless we want AI and ML and 100,000 symbols. :)
Considering
searchTerms
is a separate value, it's full customizable - ✔ will show up on searches forcheck
,tick
,correct
etc - go wild!Now here's what you came for
the search!
ooh only 2 hits so they're chonky boisss