search

samwho / symbol.wtf

A dumb website I made for when I need a symbol.
https://symbol.wtf/
MIT License
61 stars 42 forks source link

Give users the option to add symbols #55

Closed technetium closed 3 months ago

technetium commented 5 months ago

As suggested in issue #54

I've added a "+"-button at the right side of the search field. Feel free to style the button as you like.

All symbols can be edited by double clicking it. Double clicking the name will open a editbox for the name. Clicking the trashcan will remove the symbol. (Trashcan is styled in CSS, feel free to change it)

Suggestion: Change the text: "Open a PR!" to "Add it yourself" with a link to the addSymbol function. That will save to some pull requests and discussions about what symbols to include. Then the only discussion will be what will be a good set of default symbols.

Also made the symbols draggable, so users can get them in their prefered order. When a symbol is dragged the opacity is reduced to 40%, use the drag class to change the style of dragged symbols. The target of the symbol gets a solid border, the class over can be used to change that.

technetium commented 5 months ago

Preventing the deletion/change of the default symbols is extra code. To restore the defaults is a matter of removing the symbols key from the local storage. I'm on the fence regarding a button to reset to the default values: A custom layout might be gone too easy. Other option is to have the option of importing and exporting the symbols. The website gets further and further away from being dumb.

samwho commented 5 months ago

Sorry I've not gotten around to taking a closer look at this yet. I'll be travelling for work next week as well, so it's likely I won't get to this for a couple of weeks. I really appreciate the time you've put in to this, so I'm sorry for the delay.

technetium commented 5 months ago

O.K. I've scratched even more itches, but I won't bother you with yet another pull request. Let everything gradually improved.

samwho commented 3 months ago

@technetium sorry for the delay on this, but I've decided to not merge this PR. It adds a level of complexity I don't think I want to maintain in the tool. You have my blessing to fork and re-host if this is something that makes a substantial difference to your workflow. I appreciate the time and effort you've put in to contributing to symbol.wtf <3