Closed technetium closed 3 months ago
I think this has become more complex than I'm happy maintaining. I like the idea of adding custom symbols, and rearranging symbols, but I'm going to draw the line there. Saving and loading files of symbols is too much.
The pull request looks more complex than it is because all the commits from #55 are also included. b.t.w. you can see the results at https://symbol.technetium.be
On the same grounds as https://github.com/samwho/symbol.wtf/pull/55 I'm going to close this PR out. Sorry it took so long, and sorry you put the effort in only for the change to not get merged. Again, totally happy for you to fork and keep hosting it yourself.
I could not help to add a save and load button for symbol collections.
This will also solve to problem of accidental deletion of symbols. They can be restored by simply dragging the (default) collection file to the disc icon. Multiple files can be dragged together, so users can combine their own combination of symbols.
Invalid files are rejected on several levels:
When a user has created their own collection of symbols, they can save them by clicking the disk icon. Default name is symbol.json, other names are possible with the search bar.
I've included a collection of symbol collections:
default.json
, the default collection as defined in symbol.js. Suggestion: Make that definition compliant with the JSON standard, so it's easy to cut and paste in the default.json file. You can also paste the file into definition, then you have to put the array through the sanitiser. Since json can not have comments, I've put the comments in the data.hebrew.json
, intended as an example for symbol collections, chosen because the Hebrew alphabet has a limited set of characters. I leave the creation of a collection of all the Japanese Kanji for somebody else ;-)numberset.json
, when I saw you rejected the twitter-x, I had to include the symbols used for number sets. Without the twitter-x of course.I suspect when you accept all pull requests for symbols, you will end up with the complete unicode set. As you already indicated in issue #45, this is way to big not useful for most users. You could suggest users creating their own sets of symbols and accept those as PR's. You could even curtail the current default set and move some symbols to seperate collections.