Replace Deprecated `Http::request` using HttpRequestFactory

samwilson / diagrams-extension

A MediaWiki extension that displays GraphViz, Mscgen, PlantUML, and Mermaid diagrams in wiki pages.

https://www.mediawiki.org/wiki/Extension:Diagrams

GNU General Public License v2.0

8 stars 11 forks source link

Replace Deprecated `Http::request` using HttpRequestFactory #90

Closed ad1217 closed 3 months ago

ad1217 commented 3 months ago

The Http class was deprecated in MediaWiki 1.34, and seems to have been fully removed in 1.41, breaking this extension with external rendering. I've replaced it with HttpRequestFactory via MediaWikiServices::getInstance()->getHttpRequestFactory(); which I believe to be correct, but I am not very familiar with the MediaWiki PHP API so this might not be the best way to do it.

samwilson commented 3 months ago

Thanks!