search

samwilson / phpflickr

A PHP wrapper for the Flickr API, including OAuth.
https://packagist.org/packages/samwilson/phpflickr
GNU General Public License v2.0
39 stars 15 forks source link

Upgraded code base to support PHP 7.4 / 8.0 & PHPUnit 9 #46

Closed carlos-mg89 closed 2 years ago

carlos-mg89 commented 2 years ago

@samwilson would you please accept the latest pending Github action? In my local environment I was able to make the PHPUnit tests pass, by using the config.php, but in my fork I was unable to do so, even thought I have the secrets configured.

carlos-mg89 commented 2 years ago

I can see that there are some skipped tests on my PR, due to the GitHub actions not finding the Flickr environments. This is exactly what happened in my personal fork. However, in my local environment it's working.

I guess something changed in the usage of the GitHub action secrets. I've configured them, but I'm having no luck to get them passed to the GitHub action.

Anyway, I guess this PR could work for you to be able to support PHP 8.