search

samyipsh / pe

0 stars 0 forks source link

Overzealous input validation for Phone restricts duplicates #7

Open samyipsh opened 3 years ago

samyipsh commented 3 years ago

ISSUE: Unable to add tutors with the same phone number

PROBLEM: Would be preferable if the App allowed such a case by cross referencing tutor name to check if it is in fact a duplicate. This should not be too hard to implement and would help check for duplicate validation better (which I believe is the point of this function).

However it would still allow tutors who are managed by the same person / company to still be added into the app. Given the many tutoring centres, such a scenario could be quite likely and it would be beneficial to allow it.

Similarly, for Students, students may share the same phone number if they provide their home number which is often the case especially for primary school students who learn with their siblings and do not have a phone number. Restricting students with the same phone number would hence understandably cause some hinderances in trying to add them.

nus-pe-bot commented 3 years ago

Team's Response

Hi thanks for the feedback!

However, we believe that you may have misunderstood our problem scope, as we are targeting a single private tuition agency to keep track of/manage their tutors and students. Thus, each tutor will have their unique phone numbers, not under a company phone number. As for disallowing students to have duplicate phone numbers, we understand your concerns. Our team has already evaluated the probability of this happening, and we do not think it is very likely to occur as even primary school students these days have their own phones and phone numbers.

Hence, we believe that the best design choice is to still disallow duplicated phone numbers for both tutors and students.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Hi thanks for your feedback.

Your response mentioned 2 things.

  1. Tutors will have unique phone numbers because its under a single private tuition agency.
  2. Students are very unlikely to have not have phones?

(Response to point 1) This is not the case as there are many tutors that are under multiple tuition agencies (most of which if im not wrong)

(Response to point 2)This is certainly not the case as many students do not have phones.

Team conclusion: Hence, we believe that the best design choice is to still disallow duplicated phone numbers for both tutors and students. The issue still remains, it would be a better implementation to allow it, and it is a simple implementation.

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: Team did not provide any justification for reduced severity.

severity.VeryLow : A flaw that is purely cosmetic and does not affect usage e.g., a typo/spacing/layout/color/font issues in the docs or the UI that doesn't affect usage. Only cosmetic problems should have this label. severity.Low : A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only. severity.Medium : A flaw that causes occasional inconvenience to some users but they can continue to use the product.

May I check how you have categorised such a flaw to be merely cosmetic?