samyk / easel-driver

Easel driver for Linux, Mac, Windows, ARM, Raspberry Pi, Intel, FTDI, CH340, CH341, CP210x, FTDI clones, local, and remote access to GRBL-based CNC controllers
95 stars 24 forks source link

Fixing path to nvm and version issue with node-gyp #27

Closed rlancaste closed 3 months ago

rlancaste commented 3 months ago

This should fix the issue with node-gyp where it was trying to use the rU option which no longer exists. This fixes it because it uses a more up to date nodejs

It should also fix the issue where the path to node.sh is sometimes incorrect in run.sh depending on the user's configuration. Some have the file in ~/.config/nvm/nvm.sh and some have it in ~/.nvm/nvm.sh. This change using the variable should fix that since the if statement above already determines which path is correct and store it in that variable.

samyk commented 3 months ago

Thank you!