samyok / gophergrades

Used by more than 35k students to view all the past grades for classes taken at the University of Minnesota, Twin Cities.
https://umn.lol
21 stars 13 forks source link

Make RMP Search more strict #117

Closed Kanishk-K closed 5 months ago

Kanishk-K commented 7 months ago

We've received reports that the RMP connections provided are not always correct. This could be prevented by adding a validation step that verifies that the professors belong to one of the UMN-affiliated campus codes. It is more beneficial to have a false negative (where a professor is NOT found when they do exist on RMP) as opposed to a false positive (when a professor is found but is not on RMP).

adam-douiri commented 6 months ago

The code in data-app/gen_rmp.py should already throw an exception if the professor isn't at the University of Minnesota, as on line 10 the professor is fetched using both school and name. I tried to replicate the issue using Maru Sarazola, who does have a separate RMP profile for a different university, but not a UMN RMP profile. It appears Sarazola's RMP label doesn't appear as intended. Is there any specific examples of professors who's RMP connection isn't correct?

samyok commented 5 months ago

Fixed by #121