samyok / gophergrades

Used by more than 35k students to view all the past grades for classes taken at the University of Minnesota, Twin Cities.
https://umn.lol
21 stars 13 forks source link

Add proper imports to start of `add.js` #65

Closed superstealthysheep closed 1 year ago

superstealthysheep commented 1 year ago

Umm idk how to import things In add.js, I need to use some utility functions from calendar.js and date.js, but I wasn't immediately able to figure out how to import them. It seemed like I would have to turn add.js into a module or something? That sounded invasive, so I decided to not do anything like that until I asked someone more knowledgeable. So for now, I um just copied and pasted the definitions of the util functions directly into add.js.

This is very yucky and I will fix it as soon as I figure out the proper way to go about it.

Kanishk-K commented 1 year ago

Considering the completion of the SP23 additions I'm going to consider this issue complete, please re-open this if this is still something that needs to be addressed.