samyok / gophergrades

Used by more than 35k students to view all the past grades for classes taken at the University of Minnesota, Twin Cities.
https://umn.lol
21 stars 13 forks source link

responsive rmp star rating #98

Closed ca-lee-b closed 10 months ago

ca-lee-b commented 10 months ago

fixes #96

on low width screen (here i chose 450px), it only shows one star by default. this was the easiest fix i could come up with, I tried making the stars sit under the text but it resulted in a much bigger change in structure than i felt was necessary for a small fix

vercel[bot] commented 10 months ago

@ca-lee-b is attempting to deploy a commit to the umn social coding Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gophergrades ✅ Ready (Inspect) Visit Preview Nov 29, 2023 4:44pm
samyok commented 10 months ago

Hey @ca-lee-b! Thanks for contributing! Can you make sure that this PR builds when you do yarn build in the frontend/ folder? I think there may be some linting issues:

image

I bet a lot of them will be fixed just by running prettier or eslint on the files. Let me know when you've fixed that, feel free to ping me on discord (@samyok) so I look at it quicker :)