search

sanack / node-jq

Node.js wrapper for jq
MIT License
276 stars 51 forks source link

option to run jq as detached process #636

Closed sovcharenko closed 10 months ago

sovcharenko commented 11 months ago

when an app receives SIGTERM it propagates it to a child jq process and node-jq throws an error.

this makes graceful shutdown of an app impossible.

this PR allows jq to run as detached process so that SIGTERM is not propagated allowing it to exit normally.

davesnx commented 10 months ago

Hey, Thanks for the PR. Can you include a section into the REAMDE in form of docs? I belieb this can be useful to others as well

sovcharenko commented 10 months ago

Done @davesnx , have a look. I also added simple docs for cwd as they were missing

sovcharenko commented 10 months ago

qq - any chance new version will be released soon?

davesnx commented 10 months ago

Commits were not annotated properly, will run a release now.

sovcharenko commented 10 months ago

hm something's wrong. version 4.0.1 doesn't incorporate my changes

davesnx commented 10 months ago

Something seems broken in our release process, released a 4.0.2: https://github.com/sanack/node-jq/releases/tag/v4.0.2

sovcharenko commented 10 months ago

looks like there is a new problem

this is how installed node-js looks:

Screenshot_of_IntelliJ_IDEA

lib has 'old' code, while src is the latest

and package.json main refers to the stale code.

sovcharenko commented 10 months ago

feels like npm run build and npm run copy-ts-defintions didn't run during release