search

sananth12 / ImageScraper

:scissors: High performance, multi-threaded image scraper
GNU General Public License v3.0
763 stars 101 forks source link

Possible Improvement: Warn if not connected to internet. #86

Closed rw1018 closed 8 years ago

rw1018 commented 8 years ago

I received this error after running image-scraper. I didn't realize at the time my computer was disconnected from the wifi.

It might be worthwhile to throw a warning if the program cannot reach the internet.

Traceback (most recent call last): File "C:\Users\Ronald\Code\image-scrapper\env\Scripts\image-scraper-script.py", line 9, in load_entry_point('ImageScraper==2.0.7', 'console_scripts', 'image-scraper')() File "build\bdist.win32\egg\image_scraper\mains.py", line 21, in console_main File "build\bdist.win32\egg\image_scraper\utils.py", line 115, in get_html UnboundLocalError: local variable 'page' referenced before assignment

sananth12 commented 8 years ago

@rw1018 Seems like a good idea. I will add the warning. Thanks!

ssundarraj commented 8 years ago

@sananth12 I'll get working on this and send a PR.

sananth12 commented 8 years ago

@rw1018 feature added! @ssundarraj thanks!