search

sanath-2024 / fcm_v1

Simple Rust FCM server library (HTTP v1 API)
MIT License
4 stars 5 forks source link

Added Aps struct #3

Closed Jasperav closed 1 year ago

Jasperav commented 1 year ago

Instead of creating HashMaps everywhere, we can make everything typesafe. Let me know if this has your intrest.

sanath-2024 commented 1 year ago

Thanks for the PR! I agree that it is better to be type-safe instead of using HashMaps. I had created this library for personal use and I had no need for a type-safe APNs config so I just left it as is. Now I can see that other people are using it as well, so it's good to improve.

A major goal of this library (as mentioned in the README) is that we want the the FCM API to be completely supported. In other words, people shouldn't be limited in what keys they can use with the library. In that regard, I think it's best if we support all keys of APNs as listed here instead of just a subset. Let me know if you would like to work on this or have any further thoughts on the matter; otherwise, I will work on it next week (I'm busy with finals right now).

Jasperav commented 1 year ago

@sanath-2024 Ofcourse, that sounds logical. I can add the key/value pairs, that is not a lot of work.