search

sanathkr / go-npm

Distribute and install Go binaries via NPM
Apache License 2.0
171 stars 56 forks source link

Ensure the installation path exists #3

Closed jan-molak closed 7 years ago

jan-molak commented 7 years ago

When a go-npm-enabled module is installed, go-npm will pick a destination directory for said module's binary based on the output of npm bin. However, if there's no node_modules sub-directory present (which is the case when npm hoists the dependencies of such module up), the installation directory suggested by npm bin doesn't exist and the installation fails.

This fix ensures that the installation directory exists.

sanathkr commented 7 years ago

Sounds good. thanks!

jan-molak commented 7 years ago

@sanathkr - quick question, I was wondering when the next release of go-npm is scheduled for? Thanks again for your great work on this library!

jan-molak commented 6 years ago

Hi @sanathkr, any chance to get this fix released? Thanks!

jan-molak commented 6 years ago

Hi @sanathkr, sorry to bother you, but it would be awesome if you could get that patch released. Thanks in advance! 😃

jumoel commented 6 years ago

Hi @sanathkr

Any news on this? A new version would be awesome 🙂

sanathkr commented 6 years ago

https://www.npmjs.com/package/go-npm 0.1.9 is already out :)

jumoel commented 6 years ago

Awesome 👍