sanathkr / go-npm

Distribute and install Go binaries via NPM
Apache License 2.0
171 stars 56 forks source link

Allow downloading uncompressed binaries #8

Open RecuencoJones opened 5 years ago

RecuencoJones commented 5 years ago

Hi @sanathkr!

This project is awesome and I was looking forward to using it for some go packages like gomplate.

I found it was not possible to use this package if the files do not end in .tar.gz, so I created one specific strategy to handle this and refactored the code a little in order to not use too much memory.

Additionally, I found really necessary to make sure file permissions include executable.

I added a small suite of tests for these strategies that we can increase testing progressively every other part of the script, would that be ok?