Updated README with some instructions

sanathp / statusok

Monitor your Website and APIs from your Computer. Get Notified through Slack, E-mail when your server is down or response time is more than expected.

Other

1.62k stars 197 forks source link

Updated README with some instructions #34

Open saward opened 5 years ago

saward commented 5 years ago

This is a PR for docker support. It includes:

Multi-stage docker image
Ability to provide config file via an environment variable
Instructions
.gitignore and .dockerignore
Go's official modules setup with Go 1.11
A fix for a panic when dingding isn't included

I'm creating a PR for what I have in case it's useful, but I don't intend to continue using this project. I don't understand why when I run it, it tries to set up a dingding notification despite there being no such setting in my config.

BobCashStory commented 5 years ago

too many change in one Pr :/, could you split it in different parts ?

saward commented 5 years ago

Yes, it is a few changes. I don't even remember making this PR. I suspect that I did it this way because it wasn't straight forward to implement Docker support properly without these associated changes.

I'd recommend accepting or rejecting this PR as a whole, as I don't know if it would be straight forward to split it into pieces -- I suspect they are mostly connected to the overall goal of the multi-stage Docker implementation.

BobCashStory commented 5 years ago

@saward could you resolve conflict at least ?