search

sancarn / awesome-vba

A curated list of awesome VBA/VB6 frameworks, libraries, software and resources
Other
290 stars 32 forks source link

Change emojis to SVGs #17

Closed DecimalTurn closed 1 year ago

DecimalTurn commented 1 year ago

Follow up on #16

SVGs used

Platform Compatibility

Application compatibility

Other important information

Points to discuss

Are there better picks for the images?

Feel free to make changes if you find a better icon for some of them.

External dependancies or DLLs

I changed the šŸ‘½ to mean "required DLLs" since there was no other cases for its use. Is that OK? Based on the new image I used, it makes more sense to just be about DLLs. If another dependancy case occurs, we can always add another symbol.

sancarn commented 1 year ago

I changed the šŸ‘½ to mean "required DLLs" since there was no other cases for its use. Is that OK? Based on the new image I used, it makes more sense to just be about DLLs. If another dependancy case occurs, we can always add another symbol.

Could require other files like .OCX files, or .o files on Mac, or even if a file requires .xlsm files tbh... Edit: I've added a suggestion

sancarn commented 1 year ago

Additionally we need to change the contributing.md file with the new syntax. Other than that thanks so much for pushing a PR šŸ‘

DecimalTurn commented 1 year ago

If we change the text to include other dependancies than DLLs, we should also to change the image associated with it because the text in the image says DLLs.

Are there any images that you would see to represent any dependancy?

sancarn commented 1 year ago

If we change the text to include other dependancies than DLLs, we should also to change the image associated with it because the text in the image says DLLs. Are there any images that you would see to represent any dependancy?

Could use a link image, or just a file with BIN or something šŸ˜›

Edit: Alternatively we could generate some SVG which looks like a document with other documents feeding into it with arrows... e.g.

dep
   \
    Excel file
   /
dep
sancarn commented 1 year ago

VBAAwesomeDependencies - Example dependency icon

Though perhaps instead of the excel document it should be the vba icon... Which would look like this:

VBAAwesomeDependencies Example 2

DecimalTurn commented 1 year ago

Example 2 looks good, I can make the replacement and I'll accept your suggested edit.

Regarding the convention for the code references, you'll noticed that I've added a "p" in front of all the codes (eg. a_wd became pa_wd). This was based on a comment you made in the discussion and I assumed the "p" was used to mean picture. However, now that all icons will be pictures, I'm thinking we could revert back to the previous value ( eg. a_wd) for all of them to make things simpler. Thoughts?

sancarn commented 1 year ago

I'm thinking we could revert back to the previous value ( eg. a_wd) for all of them to make things simpler. Thoughts?

Yes happy to revert to the previous convention. I can't think why I used p initially but I don't think the use of p is important either.

sancarn commented 1 year ago

32-Bit modified the 32 bit symbol to remove the white background.

DecimalTurn commented 1 year ago

Thanks! Things seem good to merge now. Let me know if I missed anything.

sancarn commented 1 year ago

Looks great! Thanks for all your efforts!

DecimalTurn commented 1 year ago

Happy to help! I do think it looks great as well and hopefully easier to read for people finding the list for the first time :)

The only issue I just discovered while looking at the repo via the GitHub Android mobile app is that some SVGs don't display properly. Another PR incoming soon...