Open ThomasG08 opened 2 years ago
Thanks for the example :)
The only issue I do see is Mac compatibility. I don't think such a function exists on Mac OS, so will have to keep old functionality in the rework I imagine. I did consider this at the time, but wasnt totally sure whether it's worth the hassle of adding a different implementation for what is likely a minor improvement in speed tests. In the end:
Happy to accept a PR for this 👍
Thank you for the feedback. I will do some digging on equivalent functions on Mac and will do some digging into what randomness is introduced due to garbage collection. In the end you might probably be right - if it's so important to measure sub-millisecond runtimes one should not rely on garbage collection anyway to measure the results. If I find the results still worthwhile, I will come back with a PR.
Would this be as simple as declaring the high resolution timer as shown above and then inserting a function like this (I multiplied by 1000 to keep the units at ms):
`Public Function QPC() As Variant Dim Frequency As Currency, TickCount As Currency If QueryPerformanceFrequency(Frequency) = 0 Or QueryPerformanceCounter(TickCount) = 0 Then Exit Function QPC = (CDec(TickCount) / CDec(Frequency)) * 1000
End Function`
I made the pStartTime = QPC and pEndtime = QPC in the Initialize and Terminate procedures respectively and it seems to be working.
@ThomasG08 Looks like the equivalent for mac is mach_absolute_time
and mach_timebase_info
I'm not certain how to declare these though (yet).
As to garbage collection, looks like VBA doesn't use garbage collection.
but VBA/Excel does not have garbage collection, like old VB. Instead of GC, it uses reference counting. Memory is freed when you set a pointer to nothing (or when variable goes out of scope). Like in old VB it means that circular references are never freed.
@psilosynapse To be fair, yes, though I think I'd prefer to keep backwards compatibility. Also it seems some systems don't even have QPF function:
Public Function QueryTick() As Double
static Frequency as currency, QPFAvailable: if isEmpty(QPFAbailable) then QPFAvailable = QueryPerformanceFrequency(Frequency) <> 0
If QPFAvailable Then
Dim TickCount As Currency
if QueryPerformanceCounter(TickCount) = 0 then Exit Function 'At what point does this actually occur?
QueryTick = (CDec(TickCount) / CDec(Frequency)) * 1000
else
QueryTick = GetTickCount()
end if
End Function
@sancarn, if you are still interested in this, have a look at the code I use for timing in VBA: VBA-AccurateTimer (gist)
It's implemented fully cross-platform, and with the best possible performance as a goal.
I kept it contained to one standard module for maximum portability, but it could serve you as a handy example for the more elaborate implementation in your library, especially how to use the API functions mach_absolute_time
and mach_timebase_info
on Mac.
I'm using mach_continuous_time
instead of mach_absolute_time
but they are interchangeable with the only difference being that mach_absolute_time
does not increment while the system is asleep while mach_continuous_time
does.
@sancarn, if you are still interested in this, have a look at the code I use for timing in VBA: VBA-AccurateTimer (gist)
It's implemented fully cross-platform, and with the best possible performance as a goal. I kept it contained to one standard module for maximum portability, but it could serve you as a handy example for the more elaborate implementation in your library, especially how to use the API functions
mach_absolute_time
andmach_timebase_info
on Mac. I'm usingmach_continuous_time
instead ofmach_absolute_time
but they are interchangeable with the only difference being thatmach_absolute_time
does not increment while the system is asleep whilemach_continuous_time
does.
Ah cool thanks :) Glad it's doable on mac and good to see an implementation 👍 If you want to try your hand at a PR feel free, else I'll add it to my long todo list 😄
https://github.com/sancarn/stdVBA/blob/835bf4bece848b48c729211816e3b757bf8b1996/src/stdPerformance.cls#L67-L79
The GetTickCount Function is limited to the system timer accuracy, which is usually 10-15ms. An improvement of this accuracy could be achieved by using the API for the CPU-Performancecounter and -frequency.
Example:
Running TestPerformanceCounter will give a result similar to this: 10000 items - total: 50005000 - Runtime: 256,7 µs 100000 items - total: 5050055000 - Runtime: 1506,1 µs 1000000 items - total: 505050555000 - Runtime: 14867,8 µs 10000000 items - total: 50505055555000 - Runtime: 148550,2 µs
Edit: the variables for the QueryPerformanceCounter are passed in as currency, as the API-function requires a 64-bit Integer (LongLong) pointer, which is not available in VBA6. VBA6 supports the Currency Datatype, which is a 64-bit Integer with fixed comma. From VBA7 on, the LongLong Type could be used instead.