add support for MAC to stdSettings.cls -pb

[lopperman]

Add support for mac (look for '#If Mac' to see specific changes), primarily

• declare 'pSettingsCache' as Dictionary object, if MAC
• instantiate new 'pSettingsCache' as new Dictionary in 'Create' method, if MAC
• Modify attempting to set new worksheet codeName to only run if NOT Mac
• Modify GetIdentity -- Mac uses 'LOGNAME' instead of 'USERNAME'; MAC doesn't have 'USERDNSDOMAIN', so changed to use SandBox App Group ID;
• Recommend always using 'Application.PathSeparator' intead of hard-coded "\" or "/"

[sancarn]

Hey! PR looks good/setup correctly.

I'd like to remove the need for dependencies. Could we generally use a collection instead of a dictionary? I think this would be more ideal than including Tim H's dictionary class.

[lopperman]

Yes, I could switch to a Collection -- just want to confirm you know the dependency is Mac only, right? (Most Mac users will either have that Dictionary class, or be happy to get it. Unless I hear otherwise, I'll make the changes to remove the Dict dependency

[sancarn]

just want to confirm you know the dependency is Mac only, right?

Yes understand that, still think we should remove dependencies where possible, and in this case it is possible. Not sure what the performance detriments are of using collections, but I know Tim's class uses collections anyway so from that angle there'd be no performance loss. Also, it'll probably end up simpler and not require conditional compilation, which is a big benefit :)

[lopperman]

I committed the changes to remove the Dictionary Dependency. It looks like that just gets added to my first pull request. Is there anything else I need to do?

[lopperman]

@sancarn I didn't convert the 'PC' code to use the Collection, I'd feel more comfortable if you made those changes. At the least, still need to use precompiler directives for the GetIdentity and ignore worksheet codename for Mac (it still stops the code even with 'On Error Resume Next'). Other than that all the code could be cross platform (probably want to change the name of 'MACKeyExists' function to 'KeyExists' or something)

[sancarn]

I didn't convert the 'PC' code to use the Collection, I'd feel more comfortable if you made those changes.

Sure that's fine by me 👍 Let me know when you've finished and I'll merge 😄

[lopperman]

Should be good to go

[sancarn]

Congrats on your first PR 😄