search

sancarn / stdVBA

VBA Standard Library - A Collection of libraries to form a common standard layer for modern VBA applications.
MIT License
288 stars 60 forks source link

Performance tweaking for stdStringBuilder #73

Closed sihlfall closed 1 year ago

sihlfall commented 1 year ago

Here is the Pull Request. I have made the changes to stdStringBuilder and added some tests.

Had some problems running the tests, which I think are unrelated to StringBuilder: 1.) Use of isNumber in stdArrayTests and stdEnumeratorTests. Replacing by isNumeric fixed the issue. 2.) Some Debug.Assert False statements in stdWebSocket and stdWebSocketNew. Commenting out made the tests run.

sancarn commented 1 year ago

Perfect! Thanks a bunch for the PR! Closes #72.

sancarn commented 1 year ago

1.) Use of isNumber in stdArrayTests and stdEnumeratorTests. Replacing by isNumeric fixed the issue. 2.) Some Debug.Assert False statements in stdWebSocket and stdWebSocketNew. Commenting out made the tests run.

Thanks for reporting! :)