sanchahar / speedcrunch

Automatically exported from code.google.com/p/speedcrunch
1 stars 0 forks source link

Normalize format of numbers pasted from clipboard #434

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
When copy pasting formatted numbers (e.g., with comma separators), either strip 
commas or enhance the parser to recognize them.

Original issue reported on code.google.com by harid...@gmail.com on 15 Mar 2013 at 6:41

GoogleCodeExporter commented 8 years ago

Original comment by helder.p...@gmail.com on 15 Mar 2013 at 8:02

GoogleCodeExporter commented 8 years ago
I saw issue 58 before doling this one, and these are completely different. This 
is specifically about pasting from clipboard, the other one is about formatting 
the display. Please reopen this issue. 

Original comment by harid...@gmail.com on 16 Mar 2013 at 5:01

GoogleCodeExporter commented 8 years ago
My bad, I was induced in error by the title.

Original comment by helder.p...@gmail.com on 16 Mar 2013 at 6:02

GoogleCodeExporter commented 8 years ago
I really want to add this feature, but here's the issue: depending on where you 
come from, the format can be 1,234.56 or 1.234,56. It's trivial to act smart on 
these situations, but what about 1,234 and 1.234? In the latter case, the 
application needs to know whether comma and dot are radix characters or digit 
grouping separators. I think a setting option of some sort looks inevitable. 
What do you think? Please help me find a solution that makes sense for everyone.

Original comment by helder.p...@gmail.com on 24 Feb 2014 at 9:26

GoogleCodeExporter commented 8 years ago
Could speedcrunch use the system locale to determine how to parse commas? If 
that seems overly complicated or error prone, then a simple "Digit grouping 
character" selector or even "Ignore the following characters" setting would 
work for me.

Original comment by hutchinsfairy on 24 Jun 2014 at 9:09

GoogleCodeExporter commented 8 years ago
Issue 520 has been merged into this issue.

Original comment by helder.p...@gmail.com on 6 Aug 2014 at 12:05

GoogleCodeExporter commented 8 years ago
I like the idea of getting the radix character and digit grouping separator 
from the system locale.  Failing that, as mentioned in issue 520, I think a 
toggle in the "Settings -> Behaviour" menu would suffice.

I am totally opposed to leaving things as they are.  Regardless of where a 
particular user is from, it won't exactly be a speedy crunch if (s)he has to go 
back and remove punctuation characters from pasted numbers before proceeding.

Having a "one size fits all" approach - where both commas and dots are 
interpreted as radix characters - is both primitive and misleading.  If someone 
in the US enters "1,024" (meaning "1024"), SC will treat it as "1 radix 024".

If the user isn't aware that SC just happens to be coded this way, and doesn't 
notice that the answer to their calculation is very different from what it 
should be, SC will effectively have made a very significant error.

Also, it'd be handy for financially oriented users if SC would simply ignore 
currency symbols (e.g. $), rather than saying "invalid expression".  I 
mentioned this in issue 520 and was requested to raise the idea again here.

Original comment by Xavio...@gmail.com on 7 Aug 2014 at 8:08

GoogleCodeExporter commented 8 years ago
Please check pull request 44 for a possible implementation:
https://github.com/speedcrunch/SpeedCrunch/pull/44

In this implementation, thousand separators are detected and ignored from user 
input using 2 different methods, one of them allowing the detection of any 
character that is neither alphanumeric nor a known operator (so you can write 
"25 566$ * 65$" for instance). Also, the user chooses whether both dot and 
comma are radix characters or only one of them is a radix character (and the 
other one is detected as a thousand separator, so it is ignored).

Original comment by te...@free.fr on 26 Oct 2014 at 9:32

GoogleCodeExporter commented 8 years ago
I obviously think this is a really good patch, and I'd like to see it included 
as soon as possible.

I think the "non-SI-compliance" argument can be trumped by highlighting the 
name of this application again: SpeedCrunch.

"It won't exactly be a speedy crunch if [users have] to go back and remove 
punctuation characters from pasted numbers before proceeding."

I think the "broken exported session" argument can be overcome by including the 
radix character preferences in the text file.

Original comment by Xavio...@gmail.com on 29 Oct 2014 at 3:16