search

sanchezcarlosjr / evanotebook

EvaNotebook - A P2P Browser-Based Computational Notebook for Real Systems with IA.
https://notebook.sanchezcarlosjr.com/
MIT License
24 stars 8 forks source link

Looking for a new feature branch for exporting! #3

Open pranitsh opened 8 months ago

pranitsh commented 8 months ago

A lot of the changes I wish to make regard the database, so I'm looking for a new branch (probably not the main branch, except for some of the earlier commits) to test my features and get some more guidance on what works and what I should change. This is my first pull request, so I'm more looking for your thoughts rather than merging at the moment, especially for how this approach looks.

sanchezcarlosjr commented 8 months ago

I've provided you with the develop branch. Please use it. Additionally, every time you make a pull request, Firebase creates a preview website to showcase your progress. https://github.com/sanchezcarlosjr/evanotebook/blob/main/.github/workflows/firebase-hosting-pull-request.yml

pranitsh commented 8 months ago

Thank you for reviewing my pull request! I appreciate the feedback!

pranitsh commented 8 months ago

I've provided you with the develop branch. Please use it. Additionally, every time you make a pull request, Firebase creates a preview website to showcase your progress. https://github.com/sanchezcarlosjr/evanotebook/blob/main/.github/workflows/firebase-hosting-pull-request.yml

Oh, I didn't know, following the GitHub workflow is a bit difficult, and I kind of don't know how Firebase hosting works, since I haven't needed such a service before. I'll look into it a bit in the future, though could you clarify where this website link is if possible? I'll also use the new develop branch for the future.

pranitsh commented 8 months ago

Oh, found it: https://github.com/sanchezcarlosjr/evanotebook/actions/runs/7946059563 Yep, I rather work with the develop branch and perform PRs through that, so to still allow PRs, can we remove that workflow?

I believe I heard PRs can still allow commits. You should see new commits with some of the comments resolved by Wednesday (after some hw is due), though I would really appreciate addressing this after this discussion.

All changes follow the current license you have.

Thanks again for providing me with feedback. This is essentially my first pull request and I'm very appreciative of you taking the time to review it.