sanchezzzhak
commented
2 years ago try to use
const detector = new DeviceDetector({deviceIndexes: true});This will increase memory consumption, but reduce the time for known devices, this will also reduce the CPU load;
- use a cache for production
const createHash = (userAgent) => { return crypto.createHash('md5').update(String(userAgent)).digest('hex'); } const detect => async (userAgent) => { let result; let uaKey = 'UA:' + createHash(userAgent);
let cacheResult = await cache.get(uaKey);
if (cacheResult === void 0) {
result = deviceDetector.detect(userAgent);
await cache.set(uaKey, JSON.stringify(result), cache.TIME_15_MINUTE);
return result;
} return JSON.parse(cacheResult); }
cache adaper for memcached
```js
const Memcached = require('memcached');
//Memcached.config.debug = true;
class Memcache {
/** @typedef {Memcached} */
#cache = null;
static EVENT_FAILURE = 'failure';
static EVENT_RECONNECTING = 'reconnecting';
constructor() {
this.TIME_MAX = 2592000;
this.TIME_DAY = 86400;
this.TIME_HOUR = 3600;
this.TIME_15_MINUTE = 900;
this.adapter = new Memcached(['127.0.0.1:11211']);
}
set adapter(adapter) {
this.#cache = adapter;
}
get adapter() {
return this.#cache;
}
/**
* @param {String} key
* @param {*} val
* @param {Number} expTime
* @returns {Promise<any>}
*/
set(key, val, expTime = 3600) {
return new Promise((resolve, reject) => {
this.adapter.set(key, val, expTime, (err) => {
if (err) {
reject(err);
} else {
resolve(null);
}
});
});
}
/**
* @param {String} key
* @returns {Promise<any>}
*/
remove(key) {
return new Promise((resolve, reject) => {
this.adapter.del(key, (err, result) => {
if (err) {
reject(err);
} else {
resolve(result);
}
});
});
}
/**
* @param {String} key
* @returns {Promise<any>}
*/
get(key) {
return new Promise((resolve, reject) => {
this.adapter.get(key, (err, result) => {
if (err) {
reject(err);
} else {
resolve(result);
}
});
});
}
on(event, callback) {
this.adapter.on(event, callback);
return this;
}
end() {
this.adapter.end();
}
}
module.exports = Memcache;
MickL
petehanson
The detection is very slow and cpu intense. For me it is not usable in production. The following I tested on a Macbook 16 M1 Pro with just the sample from the readme:
PostmanRuntime/7.29.0"-> 310ms"Mozilla/5.0 (Linux; Android 5.0; NX505J Build/KVT49L) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.78 Mobile Safari/537.36"-> 86msCode: