sanctuarycomputer / herman-miller

An interactive experience built to live on Herman Miller's site, for Labour NY.
0 stars 0 forks source link

QA: Figures #25

Closed hhff closed 9 years ago

hhff commented 9 years ago
patrickdmccarthy commented 9 years ago
  1. The images are 200x200 (including the extra transparent space on top.) They were sized up to 240x240, but I've shrunk them down to 160x160 (which makes sense if we have 6 of them).

Also I've noticed this issue (you can see in the attached image) that the black figures have a white outline when they cross over other dark things. Apparently this is due to an issue called matteing(?) that occurs with with GIFs that have transparent areas.

It seems like the best way to fix this is by getting them in PNG-24 format for higher quality around the edges. Do you know if it would be possible to get those from them?

screen shot 2015-07-28 at 9 43 13 pm
patrickdmccarthy commented 9 years ago

Also, will we have different assets for all 6 of the figures that could be onscreen at any point? Wondering, since it's relevant to the construction of the filepaths for the background images.

hhff commented 9 years ago

@patrickdmccarthy - we've just recieved PNG Sprite Maps for the male and female figures: https://www.dropbox.com/sh/mmsp2ieqx2wvo4n/AACHwNCgc6lpZIq1i58UDqDGa?dl=0

Will this work for you? I was thinking something like this: http://blog.teamtreehouse.com/css-sprite-sheet-animations-steps

hhff commented 9 years ago

I'd say 3 male & 3 female, all using the same respective asset

patrickdmccarthy commented 9 years ago

Shoot, just getting a chance to take a deeper look at the assets and the article now. Two questions:

Do you think it would be possible to get new assets that just have the images going in one direction (like from left to right rather than starting new lines)?
-- I'm not really sure of a way to make it "skip" to the next line using keyframes.

One other question: does it make sense to split the walking and looking animation spritesheets? -- It seems like about 2/3 of that sheet was the looking animation, and I'm not sure how we would distinguish that the animation is in one state or another without having control of when each animation is playing.

Let me know you're thoughts, those are my main concerns but it looks doable if we answer those questions.

wyethh commented 9 years ago

Jumping in here – I sent through revised sprite sheets to Hugh, adding them here as well – feel free to ping me if they need revision. Broken out into single-line walk and look sheets for each gender. Thanks! [image: Inline image 4][image: Inline image 1][image: Inline image 3][image: Inline image 2]

On Wed, Jul 29, 2015 at 5:22 PM, patrickdmccarthy notifications@github.com wrote:

Shoot, just getting a chance to take a deeper look at the assets and the article now. Two questions:

Do you think it would be possible to get new assets that just have the images going in one direction (like from left to right rather than starting new lines)?

-- I'm not really sure of a way to make it "skip" to the next line using keyframes.

One other question: does it make sense to split the walking and looking animation spritesheets? -- It seems like about 2/3 of that sheet was the looking animation, and I'm not sure how we would distinguish that the animation is in one state or another without having control of when each animation is playing.

Let me know you're thoughts, those are my main concerns but it looks doable if we answer those questions.

— Reply to this email directly or view it on GitHub https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126098977 .

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444>

LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968> www.labour-ny.com

patrickdmccarthy commented 9 years ago

Thanks @wyethh ! Looks like you might have to reattach, though -- all I see there is [image: Inline image 4][image: Inline image 1][image: Inline image 3][image: Inline image 2]. Should be good to go though once I they're here!

wyethh commented 9 years ago

Try this – if not I'll send you a dropbox link. But it's literally 369k

On Wed, Jul 29, 2015 at 5:45 PM, patrickdmccarthy notifications@github.com wrote:

Thanks @wyethh https://github.com/wyethh ! Looks like you might have to reattach, though -- all I see there is [image: Inline image 4][image: Inline image 1][image: Inline image 3][image: Inline image 2]. Should be good to go though once I they're here!

— Reply to this email directly or view it on GitHub https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126106089 .

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444>

LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968> www.labour-ny.com

patrickdmccarthy commented 9 years ago

Sorry, seems not to be attaching... Try the dropbox link i guess?

wyethh commented 9 years ago

https://www.dropbox.com/s/gf97a31bl3ktzjs/Sprites.zip?dl=0

Also – nice to have you on board! I'm guessing since I'm replying through the github relay it doesn't accept attachments. Natch

On Wed, Jul 29, 2015 at 6:05 PM, patrickdmccarthy notifications@github.com wrote:

Sorry, seems not to be attaching... Try the dropbox link i guess?

— Reply to this email directly or view it on GitHub https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126110259 .

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444>

LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968> www.labour-ny.com

patrickdmccarthy commented 9 years ago

Thanks @wyethh! Happy to help. The assets look good.
One last question, would it be possible to get the animations split into sprites of equal size? If not, I should be able to work with it, but if you could that would simplify the computations for the spriting a bunch. Let me know, not a big thing.

wyethh commented 9 years ago

Hi Patrick – do you mean taking each individual sprite and splitting it in equal halves? or do you mean having the equivalent Male and Female sprites have exactly equal number of frames?

On Thu, Jul 30, 2015 at 5:12 PM, patrickdmccarthy notifications@github.com wrote:

Thanks @wyethh https://github.com/wyethh! Happy to help. The assets look good.

One last question, would it be possible to get the animations split into sprites of equal size? If not, I should be able to work with it, but if you could that would simplify the computations for the spriting a bunch. Let me know, not a big thing.

— Reply to this email directly or view it on GitHub https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126489021 .

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444>

LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968> www.labour-ny.com

wyethh commented 9 years ago

what I meant to say was – do you mean taking each individual sprite sheet and splitting it in equal numbers of frames?

On Thu, Jul 30, 2015 at 5:42 PM, Wyeth Hansen wyeth@labour-ny.com wrote:

Hi Patrick – do you mean taking each individual sprite and splitting it in equal halves? or do you mean having the equivalent Male and Female sprites have exactly equal number of frames?

On Thu, Jul 30, 2015 at 5:12 PM, patrickdmccarthy < notifications@github.com> wrote:

Thanks @wyethh https://github.com/wyethh! Happy to help. The assets look good.

One last question, would it be possible to get the animations split into sprites of equal size? If not, I should be able to work with it, but if you could that would simplify the computations for the spriting a bunch. Let me know, not a big thing.

— Reply to this email directly or view it on GitHub https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126489021 .

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444>

LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968> www.labour-ny.com

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444>

LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968> www.labour-ny.com

patrickdmccarthy commented 9 years ago

Yes, I think the last thing you're saying.

Sorry I wasn't clear. If you look at the "walking" sprite and the "looking" spritesheet for both the man and then woman, the "looking" one is much longer.

I'm not sure how they're generated, but is it possible to have each figure's "looking" and "walking" sheets to be an equal number of frames?

Let me know if there's still any confusion.

hhff commented 9 years ago

:heart:

wyethh commented 9 years ago

Sure – I initially made them have different lengths so that their actions wouldn't be in exactly the same phase, and if there are a number of figures on screen they aren't syncing up and mirroring each other's actions. But if we can accomplish that variation by how long we hold on the loops, then that's good. I'll go ahead and crank those out!

On Thu, Jul 30, 2015 at 6:01 PM, Hugh Francis notifications@github.com wrote:

[image: :heart:]

— Reply to this email directly or view it on GitHub https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126505471 .

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444>

LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968> www.labour-ny.com

patrickdmccarthy commented 9 years ago

Perfect! Yeah, it should be a little easier to play around with those things on our end :)

— Sent from Mailbox

On Fri, Jul 31, 2015 at 12:09 AM, Wyeth notifications@github.com wrote:

Sure – I initially made them have different lengths so that their actions wouldn't be in exactly the same phase, and if there are a number of figures on screen they aren't syncing up and mirroring each other's actions. But if we can accomplish that variation by how long we hold on the loops, then that's good. I'll go ahead and crank those out! On Thu, Jul 30, 2015 at 6:01 PM, Hugh Francis notifications@github.com wrote:

[image: :heart:]

— Reply to this email directly or view it on GitHub https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126505471 .

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444> LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968>

www.labour-ny.com

Reply to this email directly or view it on GitHub: https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126506685

wyethh commented 9 years ago

Ding! https://www.dropbox.com/sh/djsr2fb1xbrxve9/AADRZq0Z4w9LS15tgn5HLPMDa?dl=0

let me know how those work.

On Thu, Jul 30, 2015 at 6:11 PM, patrickdmccarthy notifications@github.com wrote:

Perfect! Yeah, it should be a little easier to play around with those things on our end :)

— Sent from Mailbox

On Fri, Jul 31, 2015 at 12:09 AM, Wyeth notifications@github.com wrote:

Sure – I initially made them have different lengths so that their actions wouldn't be in exactly the same phase, and if there are a number of figures on screen they aren't syncing up and mirroring each other's actions. But if we can accomplish that variation by how long we hold on the loops, then that's good. I'll go ahead and crank those out! On Thu, Jul 30, 2015 at 6:01 PM, Hugh Francis notifications@github.com wrote:

[image: :heart:]

— Reply to this email directly or view it on GitHub < https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126505471

.

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444> LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968>

www.labour-ny.com

Reply to this email directly or view it on GitHub:

https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126506685

— Reply to this email directly or view it on GitHub https://github.com/sanctuarycomputer/herman-miller/issues/25#issuecomment-126506993 .

Wyeth Hansen wyeth@labour-ny.com cell: 917 676 8444 <+19176768444>

LABOUR 55 Meadow St, Ste 304 Brooklyn, NY 11206 office: 347 987 4968 <+13479874968> www.labour-ny.com