On Mobile: Diagrams and Diagram captions should take up content width

sanctuarycomputer / negative

4 stars 1 forks source link

On Mobile: Diagrams and Diagram captions should take up content width #55

Closed hhff closed 4 years ago

hhff commented 4 years ago

IMO, this kinda looks like a mistake:

Thoughts @brendonsanctuary ?

brendonsanctuary commented 4 years ago

@chrismekim If we could just get the caption to be full width of the diagram and content. @hhff if you could elaborate.

hhff commented 4 years ago

@brendonsanctuary this is more of a nitpick than anything. Just feels to me when I scroll on my phone that this and other diagrams should be centered in the page. Happy for it to be ignored :)

brendonsanctuary commented 4 years ago

Doesn't bother me but we should just make sure they flow inline with the copy.

@chrismekim

Let's just make sure all diagrams on mobile are full content width ( not full screen width) and have their corresponding captions full content width.

Diagrams A.: Increase caption width B. Alignment needs to match up with content width on the diagram and the list below it. D. Caption width