Closed limsohee1002 closed 1 week ago
vercel[bot]
commented
1 week ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| uniswap-docs-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 14, 2024 2:27pm |
coderabbitai[bot]
commented
1 week ago The changes introduced in this pull request encompass updates across multiple configuration and component files. Key modifications include the removal of specific ESLint plugins and rules, restructuring of the Docusaurus configuration with new navigation and footer components, updates to the package dependencies, and the introduction of new React components for icons and theme switching. Additionally, various CSS files have been modified to enhance styles and typography, while a new storage management class has been added for handling theme preferences.
| File | Change Summary |
|---|---|
.eslintrc.json |
Removed "simple-import-sort" plugin and its associated rules. |
docusaurus.config.js |
Added staticDirectories, restructured navbar and footer sections. |
package.json |
Added dependencies: @headlessui/react, classnames, js-cookie, and dev dependency @types/js-cookie. |
src/components/Icons/index.tsx |
Introduced new icon components: MiniUnicon, Github, X, Discord, Sun, Menu, Moon, and IconMap. |
src/components/ThemeSwitch/index.tsx |
Added ThemeSwitch component for toggling themes. |
src/components/base/Button/index.tsx |
Introduced TextButton, ButtonBase, and LinkBase components. |
src/css/custom.css |
Added import for infima-overrides.css, removed font.css and types.css, added new layout classes. |
src/css/font.css |
Updated @font-face declarations for 'Basel Grotesk' and 'Riegraf' fonts. |
src/css/types.css |
Added new mobile variants and adjusted typography classes. |
src/theme/Footer.tsx |
Added new Footer component with structured links. |
src/theme/Navbar.tsx |
Added new Navbar component with logo and search functionality. |
src/theme/NavbarItem.tsx |
Removed NavbarItem component. |
src/theme/Root.tsx |
Updated error handling comment in Root component. |
src/utils/storage.ts |
Added StorageManager<T> class for cookie management and theme storage. |
tailwind.config.js |
Updated nav-h spacing value and removed mobile-nav-h. |
src/css/infima-overrides.css |
Introduced new CSS file for style resets and defaults. |
🐰 In the garden where changes bloom,
New icons dance and themes consume.
With buttons bright and navs so neat,
Our code hops high on happy feet!
So let’s cheer for the updates, hooray!
A fresh new look for every day! 🌼
[!WARNING] There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.
🔧 eslint
> If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration. warning eslint@7.32.0: This version is no longer supported. Please see https://eslint.org/version-support for other options. warning eslint > @humanwhocodes/config-array@0.5.0: Use @eslint/config-array instead warning eslint > @humanwhocodes/config-array > @humanwhocodes/object-schema@1.2.1: Use @eslint/object-schema instead warning eslint > file-entry-cache > flat-cache > rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported warning eslint > file-entry-cache > flat-cache > rimraf > glob@7.2.3: Glob versions prior to v9 are no longer supported warning eslint > file-entry-cache > flat-cache > rimraf > glob > inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful. error Error: https://registry.yarnpkg.com/prelude-ls/-/prelude-ls-1.2.1.tgz: Request failed "502 Bad Gateway" at ResponseError.ExtendableBuiltin (/opt/yarn-v1.22.22/lib/cli.js:696:66) at new ResponseError (/opt/yarn-v1.22.22/lib/cli.js:802:124) at Request.(/opt/yarn-v1.22.22/lib/cli.js:66750:16) at Request.emit (node:events:519:28) at module.exports.Request.onRequestResponse (/opt/yarn-v1.22.22/lib/cli.js:142287:10) at ClientRequest.emit (node:events:519:28) at HTTPParser.parserOnIncomingClient (node:_http_client:704:27) at HTTPParser.parserOnHeadersComplete (node:_http_common:118:17) at TLSSocket.socketOnData (node:_http_client:546:22) at TLSSocket.emit (node:events:519:28)
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 71 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-9w81z54cj-uniswap.vercel.app
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 56 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 99 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-6797le7mt-uniswap.vercel.app
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 87 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-5dmgprlt3-uniswap.vercel.app
limsohee1002
commented
1 week ago Please ignore font: It seems like docusaurus is not loading the font asset. It adds italic medium weight font asset only, so it render it as italic and medium font weight right now.
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 77 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 99 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-qz4t2m6ub-uniswap.vercel.app
limsohee1002
commented
1 week ago @nahbee10 ready for review!
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 64 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 97 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-2bkm7493q-uniswap.vercel.app
nahbee10
commented
1 week ago
noticed that when it's first loaded, the nav bar is light but the bg is with the dark color
there's extra padding on the left side of footer list items
hmm seems like both above not happening on local preview. not sure why! but this latest preview has the issue: https://uniswap-docs-staging-2bkm7493q-uniswap.vercel.app/
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 80 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-9lxbmrb2c-uniswap.vercel.app
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 55 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-fkw14ow78-uniswap.vercel.app
limsohee1002
commented
1 week ago @nahbee10 it should be fixed in preview now! I couldn't see it locally, it was only on preview. I guess moving forward, we should check preview link as well!
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 70 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-13neu3mq7-uniswap.vercel.app
Description
Add navigation Add footer Add theme toggle
Type(s) of changes
Motivation for PR
12 #10 #9
How Has This Been Tested?
Applicable screenshots
https://www.loom.com/share/1f4a094c82a445e3b28997e7354ea265?sid=d2677004-be98-47e1-9b7e-113a50b14863
Follow-up PR
Summary by CodeRabbit
Release Notes
New Features
ThemeSwitchcomponent for toggling between light and dark themes.Footercomponent with structured links and social media integration.Navbarcomponent with a responsive design and search functionality.Improvements
Chores