Closed nahbee10 closed 3 days ago
vercel[bot]
commented
1 week ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| uniswap-docs-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 15, 2024 5:05pm |
coderabbitai[bot]
commented
1 week ago The pull request introduces several changes across multiple files, primarily focusing on updating dependencies, enhancing CSS styles, and modifying React components. Key updates include the addition of new packages in package.json, the introduction of a PostCSS configuration file, and the enhancement of various CSS classes. React components such as DocBreadcrumbs, DocItemLayout, and SentimentTracking have been modified for improved functionality and structure. Additionally, new components like SentimentButton have been created to facilitate sentiment tracking.
| File | Change Summary |
|---|---|
package.json |
Added dependencies: @headlessui/react, classnames, js-cookie, @types/js-cookie, postcss-import. Unchanged: typescript. |
postcss.config.js |
New configuration file created with plugins: postcss-import, tailwindcss, autoprefixer. |
src/css/custom.css |
Added new CSS classes and modified existing ones for layout and styling enhancements. |
src/theme/DocBreadcrumbs.tsx |
Modified to render without props and removed SentimentTracking component. |
src/theme/DocItem/Layout/index.js |
Introduced new component for document item layout with responsive TOC handling. |
src/theme/DocItem/Layout/styles.module.css |
Adjusted CSS rules for consistent spacing and maximum width. |
tailwind.config.js |
Updated content property to include docusaurus.config.js and modified spacing configuration. |
src/components/Icons/index.tsx |
Added new icon components: Moon, Edit, Happy, Neutral, Sad and updated IconMap. |
src/components/SentimentTracking/index.tsx |
Restructured layout and functionality, replacing external icons with local ones. |
src/components/SentimentTracking/SentimentButton.tsx |
New component created for sentiment buttons with dynamic styling and event handling. |
src/css/infima-overrides.css |
Added new rule for .navbar class to reset styles. |
src/theme/Navbar.tsx |
Changed <nav> class name to "navbar" for consistency. |
.eslintrc.json |
Adjusted ESLint rules for flexibility in prop-types, TypeScript enums, and variable usage. |
.prettierignore |
Added ignore patterns for *.hbs and *.gif files. |
| Objective | Addressed | Explanation |
|---|---|---|
| Breadcrumbs | ✅ | |
| Side nav (on this page) | ✅ | |
| Edit this page button | ❌ | No implementation for an edit button present. |
| Prev/next on the bottom | ✅ | Pagination navigation styles and layout added. |
| Feedback module | ✅ | Sentiment tracking component serves this purpose. |
package.json regarding the addition of new dependencies like classnames and @headlessui/react are directly related to the enhancements made in the navigation and theme toggle features introduced in this PR.In the garden where code does play,
New icons bloom, brightening the day.
With breadcrumbs to guide and styles anew,
A sentiment tracker, just for you!
So hop along, let’s celebrate this cheer,
For every change brings us closer, my dear! 🐰✨
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 78 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-42ghrqjtd-uniswap.vercel.app
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 54 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-ptwk2276o-uniswap.vercel.app
github-actions[bot]
commented
1 week ago | Category | Score |
|---|---|
| 🟠 Performance | 65 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 99 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-dib9jtyce-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 60 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-lfhtw6xbs-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 70 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 99 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-9uyhje1sj-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 70 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 99 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-8avgs91kn-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 79 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 99 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-dnkdrpvih-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 67 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 99 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-pio6rs91l-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 89 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 99 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-4hykpuf8b-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 71 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 97 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-7i6pnobm1-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 86 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-qf9q37ii0-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 84 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-6v407gu90-uniswap.vercel.app
github-actions[bot]
commented
6 days ago | Category | Score |
|---|---|
| 🟠 Performance | 67 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 99 |
| 🟢 Accessibility | 96 |
| 🟠 Best practices | 83 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-mb8otkb1b-uniswap.vercel.app
github-actions[bot]
commented
3 days ago | Category | Score |
|---|---|
| 🟠 Performance | 71 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 85 |
| Category | Score |
|---|---|
| 🟢 Performance | 98 |
| 🟢 Accessibility | 96 |
| 🟢 Best practices | 92 |
| 🟠 SEO | 82 |
Lighthouse ran on https://uniswap-docs-staging-8lp1wipy9-uniswap.vercel.app
Description
Type(s) of changes
Motivation for PR
How Has This Been Tested?
Tested on local
Applicable screenshots
https://www.loom.com/share/a699a961c2c54c68bce79a43b0634ed2?sid=48a51aea-afee-4946-85e4-c3d708d253d0
Follow-up PR
Summary by CodeRabbit
Release Notes
New Features
SentimentButtoncomponent for improved sentiment tracking.Bug Fixes
DocBreadcrumbscomponent by removing unnecessary prop forwarding and components.Chores
package.jsonwith new dependencies for improved functionality.Documentation