sand4rt / ftp-deployer

Simple SFTP / FTP deployment with NodeJS.
https://github.com/marketplace/actions/ftp-deployer
MIT License
47 stars 12 forks source link

Actions not works after upgrade from 1.4 to 1.5 #19

Closed BaseMax closed 1 year ago

BaseMax commented 1 year ago

The following job works:


    - name: FTP Deployer
      uses: sand4rt/ftp-deployer@v1.4
      with:
        sftp: true
        host: asrez.com
        port: 22
        username: username
        password: ${{ secrets.FTP_PASSWORD }}
        remote_folder: '/home/maxbase/public_html/test-react/'
        local_folder: 'build/'
        cleanup: false
        include: '[ "*", "**/*" ]'
        exclude: '["node_modules/**", "_secret.php", ".github/**", ".git/**", "*.env"]'
        pasive: true

But when you change version from 1.4 to 1.5, It not works (Also we must remove pasive):


    - name: FTP Deployer
      uses: sand4rt/ftp-deployer@v1.4
      with:
        sftp: true
        host: asrez.com
        port: 22
        username: username
        password: ${{ secrets.FTP_PASSWORD }}
        remote_folder: '/home/maxbase/public_html/test-react/'
        local_folder: 'build/'
        cleanup: false
        include: '[ "*", "**/*" ]'
        exclude: '["node_modules/**", "_secret.php", ".github/**", ".git/**", "*.env"]'
sand4rt commented 1 year ago

Hi @BaseMax, do you get an error?

BaseMax commented 1 year ago

Hi Sander, Thank you for your message. Note I wanted to present and use this package in one of my recent talks and I did that at the conference with the old version. so I cannot remember the details of the errors in the new version. You can easily create a test repository and test the Workflow. Thank you so much. @sand4rt P.S: I presented this package in my talk with reference and thanks for sharing useful things.

sand4rt commented 1 year ago

Pasive is renamed too passive that's why you received that error. I can't do anything about that unfortunately. People who copy the new configuration will not be affected by this.