search

sand4rt / playwright-ct-angular

Playwright Angular component testing.
https://www.npmjs.com/package/@sand4rt/experimental-ct-angular
MIT License
48 stars 4 forks source link

Support for Angular 16 #23

Open rainerhahnekamp opened 1 year ago

rainerhahnekamp commented 1 year ago

When I upgrade to Angular 16 and install the dependencies of the example app via npm, playwright test fails with the following error message:

TypeError: plugin.default is not a function

You can take a look at it here: https://github.com/rainerhahnekamp/playwright-ct-angular/tree/ng-16.2

sand4rt commented 1 year ago

Hey @rainerhahnekamp 👋 Thanks for creating the issue. Will look into it. I always enjoy your talks BTW, especially about testing :) If you have more feedback or want to help out, please let me know!

rainerhahnekamp commented 1 year ago

Hello, thank you very much for the compliment. I will definitely do more now in the area of component testing with Playwright. It is quite possible that one of my next videos/talks is about this project here.

rainerhahnekamp commented 1 year ago

@sand4rt Unfortunately I don't know how to reach you. Would it be possible for you to contact me at rainer.hahnekamp@gmail.com? I would like to discuss options on how to get your work merged into Playwright.

Thank you.

sand4rt commented 11 months ago

Hey @rainerhahnekamp the TypeError: plugin.default is not a function error should be gone now. I haven't fully tested Angular 16 yet. Do you see any other issues?

BTW, cool that you recently gave a workshop to a colleague of mine😄

rainerhahnekamp commented 11 months ago

Hello @sand4rt, thanks a lot. I will check it out and let you know.

I was not aware that a colleague of yours was part of that workshop. What a coincidence :)

sand4rt commented 10 months ago

Hi @rainerhahnekamp, I wanted to inform you that there's an open PR at the Playwright repository for merging this library. Your feedback would be valuable there as well :) https://github.com/microsoft/playwright/pull/27783

rainerhahnekamp commented 10 months ago

Thanks @sand4rt, haven't done so much in terms of Playwright component testing (except producing hot air ;) ). So, I will show up there and cheer you up a little bit.