search

sand4rt / playwright-ct-web

Playwright Web component testing.
https://www.npmjs.com/package/@sand4rt/experimental-ct-web
MIT License
41 stars 3 forks source link

Not possible to test using attributes #5

Open rstoneIDBS opened 1 year ago

rstoneIDBS commented 1 year ago

I'm just trying out your library and have found that its not possible to set attributes on components, some of our components don't map properties to attributes so can't be tested. I've created a very small patch to fix this if you are interested in pulling it in.

sand4rt commented 1 year ago

@rstoneIDBS Awesome, would be great!

rstoneIDBS commented 1 year ago

@rstoneIDBS Awesome, would be great!

I'm not entirely sure how to get this to you - do I need to fork this repo? Edit: I tried to create a branch but wasn't allowed.

sand4rt commented 1 year ago

Yeah, you will need to:

  1. Fork the repo
  2. Clone the forked repo
  3. Create a branch
  4. Commit the changes (using conventional commit) eg. fix: render attributes
  5. Go to the PR section in GitHub and you are able to create the PR there