search

sandboxnu / ScoutTrek-Frontend

The future of Scouting
Other
1 stars 0 forks source link

Add type annotations to frontend #28

Closed IrisLiu-00 closed 1 year ago

IrisLiu-00 commented 1 year ago

closes #26

Fixes most of the type errors you get in your IDE when viewing the frontend files. This includes adding type annotations to function arguments, and adding types to the navigation stack stuff.

IrisLiu-00 commented 1 year ago

I'm getting this error when trying to create an event (when inputting the date) that wasn't happening on master -- any idea what it might be?

I tried to reproduce this error on my machine, but somehow instead of getting that, I just get stuck in the date input dialogue again. I don't really get any error logs either, so no clue what's happening here... 😓

Also could you remind me -- this PR addresses many of the type errors but not all right?

Yes that's correct - the main parts I didn't touch were things that looked like they would be used for the form rewrite, since I assumed that it would just get all rehauled anyways. I think there were also some small things related to specific libraries that the project uses, but it would have taken me a while to do research and figure that stuff out - so I figured it would be better to just leave it for the next time we do work with that stuff.