sandboxnu / graduatenu

Northeastern class scheduler based on degree audit.
https://graduatenu.com
GNU General Public License v3.0
25 stars 4 forks source link

Select use placeholder #705

Closed AngelaZQ1 closed 9 months ago

AngelaZQ1 commented 9 months ago

Description

Closes #696

Use react-select's placeholder attribute which lets you set placeholder text that is gray instead of black. Replaced noValueOptionLabel with placeholder which also removes the default value option from the list.

Other minor changes:

Before:

https://github.com/sandboxnu/graduatenu/assets/92692008/95716e7d-524c-4821-9b9c-6b9dd74c3fcc

After:

https://github.com/sandboxnu/graduatenu/assets/92692008/66f4ec1a-0a29-4799-98ee-6b2777b7aa4f

Type of change

Please tick the boxes that best match your changes.

How Has This Been Tested?

Please describe how you tested this PR (both manually and with tests) Provide instructions so we can reproduce.

Checklist:

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graduatenu-frontend-v2 ❌ Failed (Inspect) Feb 8, 2024 11:50pm
AngelaZQ1 commented 9 months ago

@BrandonLim8890 im gonna implement disabling the button until all fields are filled out in https://github.com/sandboxnu/graduatenu/pull/704/ since I think it makes more sense there