search

sanddudu / upyun-ghost-store

Ghost Upyun storage module
MIT License
18 stars 5 forks source link

Breaking changes in Ghost 0.10.0 #2

Closed kirrg001 closed 8 years ago

kirrg001 commented 8 years ago

Hey!

We will soon release Ghost 0.10.0 - in about 2 days. It contains breaking changes for the storage adapter, see https://github.com/TryGhost/Ghost/wiki/Using-a-custom-storage-module.

sanddudu commented 8 years ago

@kirrg001 Thank you, I will push a new version as fast as I can.

sanddudu commented 8 years ago

@kirrg001 Are all these functions need to be functional? The module doesn't needs "exist" and "delete" functions.

sanddudu commented 8 years ago

@kirrg001 I have seen there are theme upload/download/delete functions in local storage module. Does that mean there 3rd-party storage module need to support these features too?

sanddudu commented 8 years ago

@kirrg001 By the way, the base class isn't necessary to my module too. If Ghost forced my modules to require that, users using this module and startup Ghost as a module will crash because they can't access Ghost core folder as usual (the location of contents folder is different than normal).

sanddudu commented 8 years ago

@kirrg001 One more question, how can I test my modules if it works properly on Ghost 0.10.0? Is the master branch has these breaking changes now?

kirrg001 commented 8 years ago

You can test your storage adapter with the current master in Ghost. If you find any problems/bugs, we are very happy about a report.

All functions exists, delete, save, serve are required, but they can be just empty. We are planning to extend the usage of storage adapters. So in the near features, a custom storage adapter can be used to store images, themes and apps.

Uploading themes is restricted in 0.10.0 to the local-file-store, so you don't have to change nothing except that your storage adapter passes the storage validation.

If you have more questions, can you please swing by our slack channel?Thanks :)

sanddudu commented 8 years ago

@kirrg001 Got it. Thanks for your answer.

sanddudu commented 8 years ago

Fixed