use proper adv data type when non-connectable, but scan data present

sandeepmistry / arduino-BLEPeripheral

An Arduino library for creating custom BLE peripherals with Nordic Semiconductor's nRF8001 or nR51822.

MIT License

462 stars 179 forks source link

Closed floe closed 7 years ago

floe commented 7 years ago

Fixes #157 .

sandeepmistry commented 7 years ago

Hey @floe,

Thanks for taking the time to submit this PR!

Do you have a link to the description of the BLE_GAP_ADV_TYPE_ADV_SCAN_IND value? Just wondering if the peripheral would still be connectable ...

floe commented 7 years ago

No, ADV_SCAN_IND means non-connectable, but accepts scan requests. I don't have the exact reference to the Bluetooth spec ready, but see https://devzone.nordicsemi.com/question/31137/adding-more-scan-response-data/ for example.

sandeepmistry commented 7 years ago

@floe great, thank you!