search

sandeepmistry / arduino-CAN

An Arduino library for sending and receiving data using CAN bus.
MIT License
696 stars 237 forks source link

for esp32 chips with version V3 #97

Open Sheimy opened 2 years ago

Sheimy commented 2 years ago

for esp32 chips with version V3 you need to change Update ESP32SJA1000.cpp

writeRegister(REG_IER, 0xef); // enable all interrupts like this

aldoir commented 2 years ago

I've tested this with both V3 and older boards and they work with the suggested register configuration. Safe to merge

jLynx commented 1 year ago

Works for me too. Why isn't this merged in @sandeepmistry ?

zalexzperez commented 1 year ago

Here's the commit by Kenji Takahashi on mister0wl's forked version of the library: https://github.com/sandeepmistry/arduino-CAN/pull/71/commits/232562c985cc63127036cf587e855064f54aa415

It has: modifyRegister(REG_IER, 0xef, 0xef); // enable all interrupts instead of writeRegister(REG_IER, 0xef); // enable all interrupts

Does anybody know which one is right/why they're different?